remoteproc: sysmon: fix memory leak in qcom_add_sysmon_subdev()

gscui · gregkh · commit e4539eb5c0c3 · 2023-01-14T10:16:08.000+01:00
[ Upstream commit e01ce67 ] The kfree() should be called when of_irq_get_byname() fails or devm_request_threaded_irq() fails in qcom_add_sysmon_subdev(), otherwise there will be a memory leak, so add kfree() to fix it. Fixes: 027045a ("remoteproc: qcom: Add shutdown-ack irq") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20221129105650.1539187-1-cuigaosheng1@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
@@ -625,7 +625,9 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
 		if (sysmon->shutdown_irq != -ENODATA) {
 			dev_err(sysmon->dev,
 				"failed to retrieve shutdown-ack IRQ\n");
-			return ERR_PTR(sysmon->shutdown_irq);
+			ret = sysmon->shutdown_irq;
+			kfree(sysmon);
+			return ERR_PTR(ret);
 		}
 	} else {
 		ret = devm_request_threaded_irq(sysmon->dev,
@@ -636,6 +638,7 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
 		if (ret) {
 			dev_err(sysmon->dev,
 				"failed to acquire shutdown-ack IRQ\n");
+			kfree(sysmon);
 			return ERR_PTR(ret);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -625,7 +625,9 @@ struct qcom_sysmon qcom_add_sysmon_subdev(struct rproc rproc,`
`625`	`625`	`if (sysmon->shutdown_irq != -ENODATA) {`
`626`	`626`	`dev_err(sysmon->dev,`
`627`	`627`	`"failed to retrieve shutdown-ack IRQ\n");`
`628`		`- return ERR_PTR(sysmon->shutdown_irq);`
	`628`	`+ ret = sysmon->shutdown_irq;`
	`629`	`+ kfree(sysmon);`
	`630`	`+ return ERR_PTR(ret);`
`629`	`631`	`}`
`630`	`632`	`} else {`
`631`	`633`	`ret = devm_request_threaded_irq(sysmon->dev,`
`@@ -636,6 +638,7 @@ struct qcom_sysmon qcom_add_sysmon_subdev(struct rproc rproc,`
`636`	`638`	`if (ret) {`
`637`	`639`	`dev_err(sysmon->dev,`
`638`	`640`	`"failed to acquire shutdown-ack IRQ\n");`
	`641`	`+ kfree(sysmon);`
`639`	`642`	`return ERR_PTR(ret);`
`640`	`643`	`}`
`641`	`644`	`}`