Task: T-0004 Expand direct test coverage for heru adapters and base.py
Stage: accepting
Stage owner: reviewer
Process profile: Python
Task type: -

Workspace context:
# heru — Litehive Workspace Context

Process profile: Python

You are editing **heru**, a unified headless CLI for coding agents
(codex, claude, copilot, gemini, opencode, goz). Read this whole file
before touching any file in this repository.

## Project

- **Purpose:** a thin adapter layer that wraps each supported agent CLI
  behind a uniform Python interface, with a unified `heru <engine>
  <prompt>` command, one JSONL event schema across engines, and one
  resume mechanism. heru is the engine-I/O layer; it knows nothing
  about task queues, stages, orchestration, or sandboxing — those are
  litehive concerns.
- **Main package:** `heru/` (at the repo root, below `.git/`). Public
  API lives in `heru/__init__.py`, `heru/base.py`, `heru/types.py`,
  and each `heru/adapters/<engine>.py`. Anything prefixed with `_` is
  internal.
- **Commands to know:**
  - `uv sync --extra dev` — install heru's own venv
  - `uv run pytest` — heru's standalone test suite
  - `uv run heru <engine> <prompt>` — the CLI (WIP per task T-0002)
  - `cd ~/git/litehive && uv run pytest -q tests/test_runner_workflow.py tests/test_engine_variants_and_timeline.py tests/test_heru_cli.py tests/test_codex_quota.py` — **litehive contract smoke tests; run before every commit**

## Directory layout

```
heru/
├── heru/                  # the Python package
│   ├── __init__.py        # get_engine, ENGINE_CHOICES — PUBLIC
│   ├── base.py            # ExternalCLIAdapter, CLIInvocation, run_live — PUBLIC
│   ├── types.py           # shared pydantic types — PUBLIC
│   ├── main.py            # `heru <engine> <prompt>` CLI entry — PUBLIC
│   ├── _engine_detection.py   # internal
│   ├── _continuation.py       # internal
│   ├── adapters/
│   │   ├── codex.py, _codex_impl.py         # CodexCLIAdapter PUBLIC, _impl internal
│   │   ├── claude.py, _claude_impl.py
│   │   ├── copilot.py, _copilot_impl.py
│   │   ├── gemini.py, _gemini_impl.py
│   │   ├── opencode.py, _opencode_impl.py
│   │   ├── goz.py, _goz_impl.py
│   │   └── common.py      # shared helpers
│   └── quota/             # per-provider quota check helpers — PUBLIC
├── tests/                 # heru's standalone unit tests (no litehive imports)
├── pyproject.toml
├── README.md
└── .litehive/             # this workspace (tasks, state)
```

## Public API surface — do not break without a semver bump

Anything **not** prefixed with `_` is public. Changing the signature,
return type, or behavior of any of the following is a **semver-major**
breaking change that requires a version bump in `pyproject.toml`, a
CHANGELOG entry, and a migration note for litehive:

- `heru.get_engine(name)`, `heru.ENGINE_CHOICES`
- `heru.base.ExternalCLIAdapter` (subclass, don't modify shape)
- `heru.base.CLIInvocation`, `heru.base.CLIExecutionResult`
- Each adapter class: `CodexCLIAdapter`, `ClaudeCLIAdapter`,
  `CopilotCLIAdapter`, `GeminiCLIAdapter`, `OpencodeCLIAdapter`,
  `GozCLIAdapter`
- Every pydantic model in `heru/types.py`
- `heru.main.main` (the CLI entry)

**Internal** (change freely, no semver implications): every
`_`-prefixed module, every private method on public classes, and the
exact text of rendered transcripts.

## Hard rules — do NOT break these

1. **No imports from `litehive`.** heru is a leaf package. One runtime
   dep: `pydantic`. If your diff adds `from litehive …`, stop — the
   code belongs in litehive, not heru.

2. **Do not break litehive.** litehive depends on heru via an editable
   path install, so every heru change propagates immediately. Before
   you finish any stage that touched code, you MUST run:
   ```
   cd ~/git/litehive && uv run pytest tests/test_runner_workflow.py \
       tests/test_engine_variants_and_timeline.py \
       tests/test_heru_cli.py tests/test_codex_quota.py -q
   ```
   If any fail, your change broke the contract. Either fix heru to
   preserve the contract, or explicitly call out the breakage in your
   stage report with a proposed litehive-side migration.

3. **Stage reports are a litehive concept, not heru's.** `StageReport`,
   `StageResultSubmission`, `StageResultTests`, and `TaskUpdateSubmission`
   currently live in `heru/types.py` as a temporary compromise — they
   are slated to move to litehive. Do not add new stage-report logic
   or fields inside heru. If your task requires you to edit stage
   report semantics, flag it back: it is misfiled and belongs in
   litehive.

4. **Tests must be standalone.** No test under `tests/` may import
   from `litehive`. Every heru test must run in a fresh venv with
   only `heru + pydantic + pytest` installed. For JSONL fixtures,
   hand-craft strings or files under `tests/fixtures/` — do NOT
   shell out to real engine CLIs during tests.

5. **Respect the contract tests** (once `tests/contract/` exists per
   T-0007). Changing an assertion in `tests/contract/` is by
   definition a breaking change and requires the full semver
   checklist.

6. **Every new adapter needs both a public class AND a `_impl` helper
   module.** Shape: `adapters/<engine>.py` for the public class,
   `adapters/_<engine>_impl.py` for parsing/quota internals. Keep the
   symmetry — the base class expects it.

## Before you write code — ask yourself

- **Is this a heru concern or a litehive concern?** If you need task
  queues, retries, worktrees, commit pipelines, sandbox profiles, or
  the `STAGE_RESULT:` agent protocol, this is probably litehive.
  Stop and surface the concern in grooming.
- **Does this change the public API?** If yes, note the intended
  semver bump in your report and explicitly list what litehive needs
  to update.
- **Can I write this as a fixture-driven unit test?** If not, your
  code is probably too coupled to the real CLI subprocess — refactor
  to take parsed inputs.
- **Have I run the litehive contract tests?** If not, the task is not
  done, no matter what your implementation report says.

## Relationship to litehive

heru is maintained **alongside** litehive at `~/git/litehive`. They
share a developer (you) and live on the same laptop. litehive depends
on heru via `uv add --editable ~/git/heru`, so every heru save is
immediately visible to litehive without any reinstall.

**If a heru task requires changes in litehive to stay consistent**
(e.g. adding a new adapter method that litehive needs to call), open
a companion task in the litehive workspace referencing this task,
and land the heru side FIRST. Litehive can then safely bump its own
expectations.

## Process overlay
- Source of truth: tasks and implementation state live under `.litehive/`.
- Task source of truth: issues or task records define scope; prompts and transcripts are supporting evidence.
- Orchestrator model: the local runner is the manager and owns stage routing.
- Routing model: routing stays deterministic and local; subagents execute assigned stages but do not self-route.
- Shared stages: grooming -> implementing -> testing -> accepting -> commit_to_git.
- Role model: `planner` frames the task, `reviewer` performs final PM-style acceptance, `swe` edits code, and `qa` runs focused verification.
- TDD expectations: add or update focused tests near the changed Python module before broad suites.
- Verification discipline: prefer targeted `pytest` evidence close to the changed module before broader smoke coverage.
- Acceptance flow: verify behavior with targeted `pytest` coverage and note any residual risk.
- Commit and recovery: keep checkpoint commits deterministic and easy to recover.

## Project overlay
- Python package or application workflow with pytest-oriented verification.
- Favor incremental, reviewable changes over broad refactors.
- Keep implementation, verification, and acceptance evidence explicit.
- Prefer focused `pytest` coverage for the changed modules.
- Keep dependency and packaging changes explicit and minimal.

## Init scaffold
- Scaffold `.litehive/context.md` from the generic base process template.
- Layer the project profile summary, workspace overlay, and stage overlay onto that base.
- Treat process profiles as overlays on the shared contract rather than separate workflows.
- Keep the task/issue source of truth, verification commands, and recovery policy visible in the scaffold.
- Seed Python workspaces with package layout, test entrypoints, and `uv` or virtualenv expectations.

## Prompt scaffold
- Start from the shared process contract, then add repository context and task data.
- Combine the generic base prompt with the selected project overlay instead of replacing the base.
- Apply stage defaults first, then append any project-specific stage overlay for that step.
- Keep stage prompts explicit about role, verification expectations, and final report format.

## Stage prompt scaffolding

### grooming
Act as the planner: clarify the user problem, inspect the repo if needed, and produce a concrete execution plan.
Focus on scope clarification, acceptance criteria quality, decomposition, follow-up tasks, and PM sizing.
Do not make code changes in this stage.

### implementing
Implement the task in this repository.
Keep changes tightly scoped and complete the work needed for the acceptance criteria.
Write tests so each assertion would fail if the feature is broken.
Do not spend test coverage on framework behavior or library guarantees.
Do not add tests that only restate defaults, constants, or static data.
Keep each test focused on one behavior.
Avoid duplicate coverage; extend an existing test only when it is the same behavior.
- Write or update focused tests alongside the code change when feasible.
- Use `pytest` for automated verification.
- Use `tmp_path` or pytest fixtures instead of manual tempfiles in repo code or `/tmp` setup.
- Mock external calls and integration edges, not the internal logic under test.
- Do not use `time.sleep` in tests; use deterministic synchronization or time control.

### testing
Validate the implementation.
Run focused checks or tests where possible and report failures precisely.
Only make minimal fixes if absolutely necessary.
Reject tests whose assertions would still pass if the feature were broken.
Reject tests that duplicate existing coverage instead of covering a new behavior.
Reject tests longer than 50 lines unless a shorter structure is genuinely impossible.
Reject monolithic tests that exercise 5 or more behaviors in one flow.
- Prefer targeted `pytest` invocations before broader test commands.
- Verify new or updated tests use `pytest` idioms and fixtures.
- Reject tests that use manual tempfiles where `tmp_path` would make isolation explicit.
- Reject tests that mock the unit's internal logic instead of external boundaries.
- Reject tests that rely on `time.sleep` instead of deterministic control.

### accepting
Act as the reviewer: validate the end-user outcome against the acceptance criteria and decide whether it should be accepted or sent back.
Be strict about regression detection, evidence quality, and final done versus not-done judgment.

## Python specifics
- Prefer `pytest` for automated verification.
- Keep module boundaries and import hygiene clear.
- Record virtualenv, `uv`, or toolchain expectations when they matter.

## Development rules
- Keep changes scoped to the current task.
- Prefer targeted tests over broad test suites.
- Record assumptions clearly in the final report.

## Tool usage
- Use `uv run pytest -q` for the current smoke test suite.
- Update litehive task artifacts instead of inventing external state stores.
- If you add a new command or workflow, document it here for future runs.

Shared process:
- Orchestrator model: the local runner is the manager and owns stage routing.
- Routing model: routing stays deterministic and local; subagents execute assigned stages but do not self-route.
- Shared stages: grooming -> implementing -> testing -> accepting -> commit_to_git.
- Role model: `planner` frames the task, `reviewer` performs final PM-style acceptance, `swe` edits code, and `qa` runs focused verification.
- Source of truth: tasks and implementation state live under `.litehive/`.
- Task source of truth: issues or task records define scope; prompts and transcripts are supporting evidence.
- TDD expectations: add or update focused tests near the changed Python module before broad suites.
- Verification discipline: prefer targeted `pytest` evidence close to the changed module before broader smoke coverage.
- Acceptance flow: verify behavior with targeted `pytest` coverage and note any residual risk.
- Commit and recovery: keep checkpoint commits deterministic and easy to recover.

Project overlay:
- Python package or application workflow with pytest-oriented verification.
- Favor incremental, reviewable changes over broad refactors.
- Keep implementation, verification, and acceptance evidence explicit.
- Prefer focused `pytest` coverage for the changed modules.
- Keep dependency and packaging changes explicit and minimal.

Prompt scaffold:
- Start from the shared process contract, then add repository context and task data.
- Combine the generic base prompt with the selected project overlay instead of replacing the base.
- Apply stage defaults first, then append any project-specific stage overlay for that step.
- Keep stage prompts explicit about role, verification expectations, and final report format.

Role focus:
- You are the reviewer, a PM-style role representing the user's and product's point of view.
- Validate the strict end-user outcome, look for regressions or missing evidence, and make a final done versus not-done judgment.
- Reject work that is incomplete, weakly verified, or misaligned with the promised outcome.
- If SWE shows the requested work was already implemented before this run and provides concrete verification evidence, accept the task to normal `done` rather than inventing a special closed status.
- Use `wont_do`, `duplicate`, or `deferred` only when the task is genuinely obsolete, superseded, or duplicated.
- You may close a task as duplicate, wont_do, or deferred by including `outcome: <status>` with optional `outcome_reason` in a TASK_UPDATE block. You may park a task with `action: park`.

Stage instructions:
Act as the reviewer: validate the end-user outcome against the acceptance criteria and decide whether it should be accepted or sent back.
Be strict about regression detection, evidence quality, and final done versus not-done judgment.

Goal:
heru is 4381 lines of code but has only 26 direct unit tests at the time of the initial extraction from litehive. Most of heru's behavior is currently tested via litehive integration tests that exercise the full orchestration pipeline and cannot be run from heru alone. Add heru-native unit tests so that 'uv run pytest' inside the heru repo gives meaningful coverage independent of litehive. Each adapter should have tests for build_invocation (fresh and resume shapes), render_transcript (with fixture-based JSONL samples), extract_usage_observation, extract_continuation, and any adapter-specific helpers. base.py should have direct tests for ExternalCLIAdapter.run_live, stream_event iteration, inactivity timeout, and environment stripping. Target: roughly 3x the current coverage, ~80+ new tests.

Acceptance criteria:
- Every adapter (codex, claude, copilot, gemini, opencode, goz) has at least 10 direct unit tests exercising build_invocation, render_transcript, extract_usage_observation, extract_continuation, and any helper logic in its _*_impl.py module
- base.py has direct tests for run_live happy path, stderr-only noise with inactivity timeout (extending existing 3 tests), graceful process termination, and continuation extraction integration
- quota/ has unit tests for claude_quota, copilot_quota, and zai_quota parsing (codex already has 15 tests from the initial extraction)
- heru CLI (main.py) has end-to-end smoke tests that spawn a fake engine binary (tiny python script that emits fixture JSONL) and verify the CLI wires everything correctly
- Target: heru test count grows from 26 to at least 100 direct tests, all passing standalone via 'uv run pytest' in the heru repo
- No test in heru imports from litehive — every heru test must run in a fresh venv with only heru + pydantic + pytest installed

Plan:
- No plan defined.

PM sizing:
- Current PM complexity: moderate
- Current planned effort: l

Constraints:
- Keep changes scoped to the task.


Discussion thread:

--- [2026-04-10T19:45:42+00:00] planner (grooming) — pass ---
Verified current repo state without code changes. `uv run pytest --collect-only -q` succeeds and currently collects 80 parametrized tests; the task record baseline of 26 direct tests is stale, but the coverage gap is still real. Coverage today is concentrated in CLI option forwarding, codex quota, 3 inactivity-timeout tests, unified-event translation, and a small goz/resume slice. Direct unit coverage is still missing for most adapter surfaces (`build_invocation`, transcript rendering, usage extraction, continuation extraction, and helper parsing modules), for `base.py` process behavior beyond the existing timeout tests, for `quota/claude_quota.py`, `quota/copilot_quota.py`, `quota/zai_quota.py`, and for true heru-native CLI subprocess smoke tests.

Execution plan for implementing:
1. Add focused adapter unit suites for `codex`, `claude`, `copilot`, `gemini`, `opencode`, and `goz`, using fixture-driven JSONL payloads and direct helper tests in each `_*.py` impl module. Target at least 10 tests per adapter covering fresh vs resume invocation shapes, transcript rendering fallback paths, usage extraction, continuation extraction, and one or more adapter-specific helper behaviors.
2. Add direct `base.py` tests around `ExternalCLIAdapter.run_live` with a tiny fake subprocess script/stub adapter: happy path streaming, stderr-only noise leading to inactivity timeout, graceful terminate/kill handling, continuation extraction integration, environment stripping via `build_invocation_env`, and stream/unified-event helper coverage where assertions would fail on regression.
3. Add standalone quota parser/cache tests for `claude_quota`, `copilot_quota`, and `zai_quota`, mirroring the style of existing `test_codex_quota.py` and keeping all fetch/process calls mocked.
4. Add heru CLI smoke tests that spawn a fake engine binary/script emitting deterministic JSONL so `main.py` is verified end-to-end for stdout/stderr wiring, exit code propagation, resume/continue handling, and raw vs unified output behavior without importing litehive.
5. Run targeted pytest modules first, then `uv run pytest`, then the required litehive contract smoke suite from `~/git/litehive` before handing off.

Acceptance-criteria interpretation for next stage:
- Treat the stale 26-test baseline as informational only; the real observable target is `uv run pytest` collecting/passing at least 100 standalone heru tests on this branch.
- Keep the task scoped to heru-native tests only; no API changes, no litehive imports, no stage-report semantics work.

TASK_UPDATE:
plan:
  - Add adapter and `_impl` unit tests for all six engines with fixture-driven JSONL coverage.
  - Add direct `base.py` process-behavior tests for live execution, timeout, termination, continuation, and env stripping.
  - Add quota unit tests for Claude, Copilot, and Z.AI helpers.
  - Add end-to-end heru CLI smoke tests using a fake engine binary.
  - Verify with targeted pytest, full heru pytest, and required litehive contract smoke tests.
pm_complexity: complex
planned_effort: xl

--- [2026-04-10T19:55:51+00:00] swe (implementing) — pass ---
Added heru-native direct coverage across all six adapters, base.py, quota helpers, and subprocess CLI smoke paths. New suites cover fresh/resume invocation shapes, transcript rendering from fixture JSONL samples, usage extraction, continuation extraction, and adapter-specific helper logic for codex/claude/copilot/gemini/goz/opencode; base.py now has direct tests for run_live happy path, unified streaming, stderr-only inactivity timeout, callback-triggered teardown, environment stripping, and continuation extraction; quota coverage now includes claude/copilot/zai parser and cache/fail-open behavior; CLI smoke tests now spawn fake engine binaries and verify unified/raw wiring plus continue flow. Verification: uv run pytest --collect-only -q now collects 165 standalone heru tests, uv run pytest -q passed (165 passed in 4.05s), and required litehive contract smoke passed from ~/git/litehive (197 passed, 3 warnings). Also fixed a real base.py cleanup bug uncovered by the new tests by avoiding fragile communicate() cleanup after aborting live runs.

--- [2026-04-10T19:57:44+00:00] qa (testing) — pass ---
Validated the branch against the testing-stage acceptance criteria. Evidence: uv run pytest --collect-only -q in heru collects 165 standalone tests, so the repo exceeds the 100-test target. Targeted verification passed with uv run pytest -q tests/test_base_direct.py tests/test_codex_adapter_direct.py tests/test_claude_adapter_direct.py tests/test_copilot_adapter_direct.py tests/test_gemini_adapter_direct.py tests/test_goz_adapter_direct.py tests/test_opencode_adapter_direct.py tests/test_quota_parsers.py tests/test_cli_smoke.py (85 passed). Full heru suite passed with uv run pytest -q (165 passed in 4.08s). Required litehive contract smoke also passed from /home/alexey/git/litehive with uv run pytest tests/test_runner_workflow.py tests/test_engine_variants_and_timeline.py tests/test_heru_cli.py tests/test_codex_quota.py -q (197 passed, 3 Typer deprecation warnings only). I also checked policy compliance with rg and found no litehive imports under tests. Direct adapter coverage meets the per-adapter minimum: claude 11 tests, codex 13, copilot 10, gemini 10, goz 10, opencode 10, covering fresh/resume/continue invocation shapes, transcript rendering from fixture JSONL, usage extraction, continuation extraction, and helper logic in the _impl modules. tests/test_base_direct.py covers ExternalCLIAdapter.run_live happy path, unified stream-event emission, stderr-only inactivity timeout, graceful termination on callback abort, environment stripping, and continuation extraction integration. tests/test_quota_parsers.py covers claude/copilot/zai quota parsing and cache/fail-open behavior. tests/test_cli_smoke.py provides end-to-end smoke coverage with fake engine binaries for unified output, raw output, and continue wiring. Verdict: PASS.

IMPORTANT: When you are done, you MUST submit your verdict by running:
  litehive report --verdict <pass|reject> --role reviewer --step accepting --message "<your report>"
The environment variable LITEHIVE_TASK_ID is set to T-0004 for this session. Workspace and task resolution should use the injected environment automatically.

Your --message is the PRIMARY way the next agent understands what happened.
Do NOT rely on your raw transcript being read — write the report as if it is the only thing the next agent will see.

Report requirements:
- On PASS/ACCEPT: explain what you verified, what tests you ran, what evidence confirms the acceptance criteria are met.
- On REJECT: you MUST include ALL of the following:
  1. EXPECTED behavior: what should happen according to the acceptance criteria
  2. OBSERVED behavior: what actually happens (exact error messages, test output, wrong values)
  3. Steps to reproduce: the exact command or test that demonstrates the gap
  4. Which acceptance criteria are not met and which ones are already satisfied

A vague rejection like 'tests fail' or 'missing evidence' is useless and causes infinite loops.
A good rejection looks like: 'Expected: `litehive engine gemini` switches the default engine and prints confirmation. Observed: command exits 0 but config.yaml still shows the old engine. Reproduce: run `litehive engine gemini` then `cat .litehive/config.yaml`. Criteria 1-3 are met, criterion 4 (persistence) is not.'
