remoteproc: sysmon: fix memory leak in qcom_add_sysmon_subdev()

gscui · gregkh · commit 27441fab2651 · 2023-01-18T11:41:31.000+01:00
[ Upstream commit e01ce67 ] The kfree() should be called when of_irq_get_byname() fails or devm_request_threaded_irq() fails in qcom_add_sysmon_subdev(), otherwise there will be a memory leak, so add kfree() to fix it. Fixes: 027045a ("remoteproc: qcom: Add shutdown-ack irq") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> Signed-off-by: Bjorn Andersson <andersson@kernel.org> Link: https://lore.kernel.org/r/20221129105650.1539187-1-cuigaosheng1@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
@@ -518,7 +518,9 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
 		if (sysmon->shutdown_irq != -ENODATA) {
 			dev_err(sysmon->dev,
 				"failed to retrieve shutdown-ack IRQ\n");
-			return ERR_PTR(sysmon->shutdown_irq);
+			ret = sysmon->shutdown_irq;
+			kfree(sysmon);
+			return ERR_PTR(ret);
 		}
 	} else {
 		ret = devm_request_threaded_irq(sysmon->dev,
@@ -529,6 +531,7 @@ struct qcom_sysmon *qcom_add_sysmon_subdev(struct rproc *rproc,
 		if (ret) {
 			dev_err(sysmon->dev,
 				"failed to acquire shutdown-ack IRQ\n");
+			kfree(sysmon);
 			return ERR_PTR(ret);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,9 @@ struct qcom_sysmon qcom_add_sysmon_subdev(struct rproc rproc,`
`518`	`518`	`if (sysmon->shutdown_irq != -ENODATA) {`
`519`	`519`	`dev_err(sysmon->dev,`
`520`	`520`	`"failed to retrieve shutdown-ack IRQ\n");`
`521`		`- return ERR_PTR(sysmon->shutdown_irq);`
	`521`	`+ ret = sysmon->shutdown_irq;`
	`522`	`+ kfree(sysmon);`
	`523`	`+ return ERR_PTR(ret);`
`522`	`524`	`}`
`523`	`525`	`} else {`
`524`	`526`	`ret = devm_request_threaded_irq(sysmon->dev,`
`@@ -529,6 +531,7 @@ struct qcom_sysmon qcom_add_sysmon_subdev(struct rproc rproc,`
`529`	`531`	`if (ret) {`
`530`	`532`	`dev_err(sysmon->dev,`
`531`	`533`	`"failed to acquire shutdown-ack IRQ\n");`
	`534`	`+ kfree(sysmon);`
`532`	`535`	`return ERR_PTR(ret);`
`533`	`536`	`}`
`534`	`537`	`}`